Don't use Pandas for SQLTableCheckOperator #25822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norm
suggested changes
Aug 19, 2022
| @@ -385,17 +385,15 @@ def execute(self, context: 'Context'): | |||
| self.sql = f"SELECT check_name, check_result FROM ({checks_sql}) " | |||
| f"AS check_table {partition_clause_statement};" | |||
|
|
|||
| records = hook.get_pandas_df(self.sql) | |||
| records = hook.get_records(self.sql) | |||
There was a problem hiding this comment.
Did you forget to commit something? Tests fail:
> records = hook.get_records(self.sql)
E AttributeError: 'MockHook' object has no attribute 'get_records'
There was a problem hiding this comment.
No, I just failed to run the rest of the tests (I only checked my new test that hits a real DB that I added in a paralell PR not the mocked one.)
Pandas is an optional extra for common-sql provider, so _forcing_ it for a query that is going to return a couple of rows is not a good idea
3acfa81 to
61a2d66
Compare
norm
approved these changes
Aug 19, 2022
kaxil
approved these changes
Aug 19, 2022
eladkal
approved these changes
Aug 19, 2022
potiuk
approved these changes
Aug 19, 2022
25 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas is an optional extra for common-sql provider, so forcing it for
a query that is going to return a couple of rows is not a good idea.
(We didn't notice this in CI as our tests have everyting installed)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.