Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common-sql lower bound for common-sql #25789

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 18, 2022

There are some implicit dependencies for common-sql 1.1.0 version
that slipped through our understanding of cross-dependencies
(learning for the future). We are bumping dependencies of all the
packages that depend on common-sql, to reflect that


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we yank version 1.0?

@potiuk
Copy link
Member Author

potiuk commented Aug 18, 2022

Should we yank version 1.0?

Not common-sql. 1.0 is fine. But once we release the changed/fixed all providers with common-sql>=1.1.0 we should likely yank the .0 versions of those providers (once I merge this one I iwll prepare bugfix release for those providers).

There are some implicit dependencies for common-sql 1.1.0 version
that slipped through our understanding of cross-dependencies
(learning for the future). We are bumping dependencies of all the
packages that depend on common-sql, to reflect that
@potiuk potiuk force-pushed the add-lower-bound-for-common-sql branch from 4a0df44 to 383e5d2 Compare August 18, 2022 15:40
@potiuk potiuk merged commit ca9229b into apache:main Aug 18, 2022
@potiuk potiuk deleted the add-lower-bound-for-common-sql branch August 18, 2022 16:38
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 13, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:databricks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants