Adding a parameter for exclusion of trashed files in GoogleDriveHook #25675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
reviewed
Aug 11, 2022
eladkal
approved these changes
Aug 11, 2022
uranusjr
reviewed
Aug 12, 2022
eladkal
approved these changes
Aug 14, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoogleDriveHook is currently returning all the files with the specified naming, regardless if they are in the "trash folder" or not.
Taking inspiration from the following PR: #24446, I saw that the Google Drive API has a parameter that we can add to the query (
trashed=false/true) that specifies whether we want the API to return trashed files or not (default isTrue-> show trashed files).This PR is adding this query param to the
GoogleDriveHook.related: #24446