-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @task.kubernetes taskflow decorator #25663
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
@@ -147,7 +147,6 @@ class KubernetesPodOperator(BaseOperator): | |||
to populate the environment variables with. The contents of the target | |||
ConfigMap's Data field will represent the key-value pairs as environment variables. | |||
Extends env_from. | |||
:param: kubernetes_conn_id: To retrieve credentials for your k8s cluster from an Airflow connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This docstring is duplicated; there’s already one near the top, so I took the chance to remove it.
Thanks for making this cross the finish line @fletchjeff |
@fletchjeff @uranusjr Can one of you look at the failing tests please:
Feels related since those are provider failures only |
Hi @kaxil , both of those failures seem to be related to snowflake connector.
I see similar messages in the
|
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Should be fixed by #25697 -- I have rebased the PR 🤞 |
Awesome work, congrats on your first merged pull request! |
@fletchjeff Thanks for staying on top of this 🎉 |
wooooooohoooo 🎉 |
Thank you all!! Super excited to get to use this now :) |
Adds the
@task.kubernetes
decorator to run arbitrary python code in a DAG in a k8s pod using the KubernetesPodOperator.closes: #19135
This fixes some of the changes requested with pull request 21077. Shout out to @subkanthi who did most of the work, I just made the final requested changes.
The
python_kubernetes_script.py
andpython_kubernetes_script.jinja2
are now in theairflow/providers/cncf/kubernetes
folder.Co-authored-by: subkanthi subkanthi@gmail.com
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.