Add fields to dagrun endpoint #23440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* data_interval_start * data_interval_end * last_scheduling_decision * run_type
2 tasks
ephraimbuddy
reviewed
May 3, 2022
| @@ -1046,6 +1094,10 @@ def test_should_response_200_for_matching_execution_date_logical_date(self): | |||
| "external_trigger": True, | |||
| "start_date": None, | |||
| "state": "queued", | |||
| "data_interval_end": "2020-11-10T08:25:56.939143+00:00", | |||
| "data_interval_start": "2020-11-10T08:25:56.939143+00:00", | |||
There was a problem hiding this comment.
Should we use this opportunity to refactor these hardcoded dates? We could have logical_date and execution_date as constants and pass them instead of these dates?
There was a problem hiding this comment.
Thanks @ephraimbuddy, made this one and another test to use constants.
ephraimbuddy
approved these changes
May 3, 2022
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
bbovenzi
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add below fields to dagrun endpoint :
closes: #23415
related: #23415