Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slim images to release process #23391

Merged
merged 1 commit into from
May 7, 2022
Merged

Add slim images to release process #23391

merged 1 commit into from
May 7, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented May 1, 2022

This PR adds slim images to release process of Airflow.

Those images are small as they do not contain any extras.
Fixes: #20849


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes kind:documentation labels May 1, 2022
@potiuk potiuk force-pushed the slim-image branch 3 times, most recently from 822a6fb to 3ca0aeb Compare May 2, 2022 12:58
@potiuk
Copy link
Member Author

potiuk commented May 2, 2022

I also turned the bash script to prepare the image into a breeze command:

output-release-prod-images

@potiuk
Copy link
Member Author

potiuk commented May 2, 2022

BTW. This change can be merged independently from the decision whether we release slim images or not :)

The fact that we can do it, does not mean we have to :)

Discussion https://lists.apache.org/thread/g2jp5s9cqgwhltz7wd3gkxb7vnnkrp5n

@potiuk potiuk force-pushed the slim-image branch 3 times, most recently from 2d53c80 to 51a3194 Compare May 2, 2022 13:18
@potiuk potiuk requested review from eladkal and mik-laj May 2, 2022 13:29
Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks very useful :)

@potiuk potiuk force-pushed the slim-image branch 3 times, most recently from 1fe3fcf to fe1914b Compare May 5, 2022 12:59
@potiuk
Copy link
Member Author

potiuk commented May 5, 2022

All points addressed @o-nikolas -> thanks for dilligence :)

@potiuk
Copy link
Member Author

potiuk commented May 5, 2022

Updated release-prod-images command after removing backends split

output-release-prod-images

@potiuk
Copy link
Member Author

potiuk commented May 5, 2022

And here is a complete set of images for 2.3.0 on my personal account to see the end result of it : https://hub.docker.com/repository/docker/potiuk/airflow/tags?page=1&ordering=last_updated

@potiuk
Copy link
Member Author

potiuk commented May 6, 2022

I think all comments address. Thanks @jedcunningham for all the grammar corrections too :)

@potiuk potiuk force-pushed the slim-image branch 3 times, most recently from b7b0c91 to 44fa29e Compare May 7, 2022 20:16
This PR adds slim images to release process of Airflow.

Those images are small as they do not contain any extras.

Fixes: apache#20849
@potiuk potiuk merged commit 6e59558 into apache:main May 7, 2022
@potiuk potiuk deleted the slim-image branch May 7, 2022 21:53
potiuk added a commit that referenced this pull request May 12, 2022
This PR adds slim images to release process of Airflow.

Those images are small as they do not contain any extras.

Fixes: #20849
(cherry picked from commit 6e59558)
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.1 milestone May 19, 2022
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label May 19, 2022
ephraimbuddy pushed a commit that referenced this pull request May 21, 2022
This PR adds slim images to release process of Airflow.

Those images are small as they do not contain any extras.

Fixes: #20849
(cherry picked from commit 6e59558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:production-image Production image improvements and fixes changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide 'vanilla' Airflow Docker image
4 participants