Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the docstrings #22497

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Fix the docstrings #22497

merged 1 commit into from
Mar 24, 2022

Conversation

mai-nakagawa
Copy link
Contributor

I think PubSubHook is using gRPC but not REST.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

I think PubSubHook is using gRPC but not REST.
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 24, 2022
@mai-nakagawa mai-nakagawa marked this pull request as ready for review March 24, 2022 01:23
@mai-nakagawa mai-nakagawa requested a review from turbaszek as a code owner March 24, 2022 01:23
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 24, 2022
@potiuk potiuk merged commit 82a26c0 into apache:main Mar 24, 2022
@mai-nakagawa mai-nakagawa deleted the patch-2 branch April 30, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants