Require SQLAlchemy 1.4 #22114
Merged
Require SQLAlchemy 1.4 #22114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the exceptions have moved between 1.3 and 1.4 (`sqlalchemy.orm.exc import MultipleResultsFound` becomes `from sqlalchemy.exc import MultipleResultsFound`) Since we only ever test with the "latest" version we should update the requirement to be tighter to ease upgrades. (Without this the UI/API will fail to start)
potiuk
approved these changes
Mar 9, 2022
|
Very much so. That also reminded me that I had to take a look at what broke > 1.4.9 |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
itayB
added a commit
to itayB/airflow
that referenced
this pull request
Jun 24, 2022
following to this change: apache#22114
potiuk
pushed a commit
that referenced
this pull request
Jun 24, 2022
following to this change: #22114
itayB
added a commit
to itayB/airflow
that referenced
this pull request
Jun 30, 2022
following to this change: apache#22114
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 30, 2022
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
following to this change: apache/airflow#22114 (cherry picked from commit 2113d72466fc89215c5874eab4124fce06a6d751) GitOrigin-RevId: c711b76fe9e7a8c69d6c60194732b343b7b58b92
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
following to this change: apache/airflow#22114 (cherry picked from commit 2113d72466fc89215c5874eab4124fce06a6d751) GitOrigin-RevId: c711b76fe9e7a8c69d6c60194732b343b7b58b92
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 30, 2023
following to this change: apache/airflow#22114 GitOrigin-RevId: 2113d72466fc89215c5874eab4124fce06a6d751
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
following to this change: apache/airflow#22114 (cherry picked from commit 2113d72466fc89215c5874eab4124fce06a6d751) GitOrigin-RevId: c711b76fe9e7a8c69d6c60194732b343b7b58b92
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 18, 2024
following to this change: apache/airflow#22114 GitOrigin-RevId: 2113d72466fc89215c5874eab4124fce06a6d751
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2024
following to this change: apache/airflow#22114 GitOrigin-RevId: 2113d72466fc89215c5874eab4124fce06a6d751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the exceptions have moved between 1.3 and 1.4 (
sqlalchemy.orm.exc import MultipleResultsFoundbecomesfrom sqlalchemy.exc import MultipleResultsFound)Since we only ever test with the "latest" version we should update the requirement to be tighter to ease upgrades. If we don't do this, we'll have to expand our unit tests to check against SQLA 1.3 and 1.4.
(Without this the UI/API will fail to start)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.