-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added explaining concept of logical date in DAG run #21433
Conversation
Added two paragraphs under the DAG run to describe the difference between logical date and dag start and end date, and some of the reason behind its naming 'logical,' as well as providing an example.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There are sections in DAG run and FAQ pages on this as well, it may be a good idea to link them together with |
changed a bit of formatting
@uranusjr , I'm not sure which locations are you referring to in |
And yeah I think we should aim to bring all those inter-connected. I think our docuemenation has too lttle interlinking and some information is repeated in places (and often some of the variants of the descriptions are out-dated). I tend to simply run search/grep on similar terms when I update some documentation. Our documentation has pretty fast and good search (I know people aren't used to search in the documentation but I actually learned that the search here is actually very decent, fast and accurate :) https://airflow.apache.org/docs/apache-airflow/stable/index.html |
… interlink each other
Ok, added those references on each of the files mentioned above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @uranusjr ?
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
fixed the incorrect typo
done - I believe all the tests have succeeded, and the PR is ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts on wording. Generally looks nice, thanks for taking the time to put this in words! It’s inheritantly a difficult thing to explain!
sounds good! I'll commit the changes. Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
dag run does not have end date when it starts, but when it ends. Modified the description correctly.
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Awesome work, congrats on your first merged pull request! |
@howardyoo thanks! Congrats on your first commit 🎉 |
(cherry picked from commit 752d538)
Thank you!! I hope for more to come! :-) |
Added two paragraphs under the DAG run to describe the difference between logical date and dag start and end date, and some of the reason behind its naming 'logical,' as well as providing an example. The intention for this additional content is to clarify any confusions about what logical date would mean compared to the DAG run's start and end date.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.