Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ECSProtocol compat shim inheritance #20669

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Fix ECSProtocol compat shim inheritance #20669

merged 1 commit into from
Jan 5, 2022

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Jan 5, 2022 •
edited
Loading

Tests are failing:

TypeError: Protocols can only inherit from other protocols, got <class 'airflow.providers.amazon.aws.operators.ecs.ECSProtocol'>

This is due to the compatibility shim for ECSProtocol is incorrectly double-inheriting Protocol. Since #20332 already made both ECSProtocol a deprecated class (in favour of EcsProtocol), we don’t actually need that subclass now.

@uranusjr uranusjr force-pushed the fix-aws-inherit-failures branch from d03520c to ecf287a Compare January 5, 2022 07:53
@kaxil
Copy link
Member

kaxil commented Jan 5, 2022

oh .. there is #20670 from @eladkal too that address the same issue in a different way

@kaxil kaxil mentioned this pull request Jan 5, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 5, 2022
@uranusjr uranusjr mentioned this pull request Jan 5, 2022
Closed
potiuk
potiuk approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this is simplest way.

@potiuk potiuk merged commit 392c85b into apache:main Jan 5, 2022
@kaxil kaxil deleted the fix-aws-inherit-failures branch January 5, 2022 19:46
@eladkal eladkal mentioned this pull request Jan 5, 2022
Merged
@ferruzzi
Copy link
Contributor

ferruzzi commented Jan 5, 2022

Cool, I think this is the issue I was running into here as well: #20374

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@eladkal eladkal eladkal approved these changes

@kaxil kaxil kaxil approved these changes

Assignees
No one assigned
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@uranusjr @kaxil @ferruzzi @potiuk @eladkal @ephraimbuddy