Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing the gzip compression parameter on sftp_to_gcs #20553

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

qgallet
Copy link
Contributor

@qgallet qgallet commented Dec 29, 2021

This small Pull Request fixes the gzip compression handling on SFTPToGCSOperator described at #20552.

The parameter is now passed to the GCS Hook upload() call.

@qgallet qgallet requested a review from turbaszek as a code owner December 29, 2021 10:58
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Dec 29, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 29, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@qgallet qgallet changed the title Fix passing the gzip compression parameter on sftp_to_gcs #20552 Fix passing the gzip compression parameter on sftp_to_gcs Dec 29, 2021
@potiuk
Copy link
Member

potiuk commented Dec 29, 2021

Nice one. I will add it to today's release if tests pass.

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 29, 2021
@potiuk potiuk merged commit 3a480f5 into apache:main Dec 29, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 29, 2021

Awesome work, congrats on your first merged pull request!

@qgallet qgallet deleted the fix_sftp_to_gcs_gzip branch December 29, 2021 13:02
@potiuk potiuk linked an issue Dec 29, 2021 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gzip parameter of sftp_to_gcs operator is never passed to the GCS hook
2 participants