Ensure Tableau connection is active to access wait_for_state #20433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait_for_state inside of TableauHook context to ensure an a…wait_for_state inside context to ensure an active Tableau connection
eladkal
approved these changes
Dec 21, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
uranusjr
reviewed
Dec 22, 2021
| @@ -107,6 +107,7 @@ def execute(self, context: dict) -> str: | |||
| error_message = f'Method not found! Available methods for {self.resource}: {available_methods}' | |||
| raise AirflowException(error_message) | |||
|
|
|||
| job_id = "" | |||
There was a problem hiding this comment.
I added it in case the TableauHook context fails and it's left undefined. But I suppose if that were to happen, it would throw an exception and wouldn't reach return job_id anyway. I can remove it.
…ctive Tableau connection (#20432)
wait_for_state inside context to ensure an active Tableau connection
91 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve issue #20432 which is caused by the
wait_for_statecall being executed outside of theTableauHookcontext after it has logged out of the Tableau server. This code moves the call into the context so that it is executed while still logged into the Tableau server.closes: #20432