Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECSOperator: fix KeyError on missing exitCode #20264

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Conversation

ssatia
Copy link
Contributor

@ssatia ssatia commented Dec 13, 2021

exitCode is not a required property on the container status response and is missing if the container exits during the early stages of initialization. This change would lead to the missing key being interpreted as an erroneous exit code after the container is stopped, which is the desired behavior.

closes: #18089

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Dec 13, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 13, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woudl it be possible to add a unit test covering that?

@ssatia
Copy link
Contributor Author

ssatia commented Dec 15, 2021

Woudl it be possible to add a unit test covering that?

Added a UT

@ssatia ssatia requested a review from potiuk December 15, 2021 02:38
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 15, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal eladkal merged commit 206cce9 into apache:main Dec 16, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 16, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError when ECS failed to start image
4 participants