-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude snowflake-sqlalchemy v1.2.5 #20245
Conversation
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
This one will need to get constraints regenerated quickly after merge as this will generate conflicts with main constraints. Let me do it now and I can merge/push constraints |
I will also cherry-pick that one to 2.2.3 @jedcunningham |
Also @mik-laj -> I believe we should fix constraints for released airlfow version - snowflake sqlalchemy 1.2.5 is used in all constraints - 2.1.3, 2.1.4, 2.2.0, 2.2.1, 2.2.2. I guess we should downgrade those to 1.2.4 right? |
Generating the constraints now -> I will be back in ~ 1.5 h and I will merge/push constraints then (getting 3rd vaccination in 30 mins :) ) |
Constraints updated in main. Merged. |
(cherry picked from commit 044eccf)
I updated the updated constraints (snowflake-sqlalchemy = 1.2.4) for Airlfow 2.2.2 and 2.1.4. I think this is the right way to go - we should encourage people to go to the highest patchlevels anyway. |
We should actually even release an ad-hoc release of the snowflake Provider with those limitiations. I will take a look at that after we release the databricks one. |
@NadimYounes This release has been yanked, so it shouldn't be installed automatically anymore. |
@mik-laj Not sure I am following. If I try installing airflow with the snowflake provider using the command below:
It still results in the known issues with SqlAlchemy imports. Am I missing something? |
@NadimYounes -Indeed 2.2.3 constraints were prepared before snowflake was yanked. It should be fixed now. |
@potiuk Thanks for the quick turnaround on this! |
The snowflake-alchemy 1.2.5 introduces a hard dependency on
sqlalchemy>=1.4.0
, but they didn't define this requirement in setup.py, so pip cannot figure out the correct set of dependencies.See: snowflakedb/snowflake-sqlalchemy#234
This release should have been marked yanked, but Snowflake has not yet done so.
CC: @sfc-gh-abhatnagar @harishkrao
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.