Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy hack for TaskInstance without DagRun #20108

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Dec 7, 2021

Let’s see if this is even viable first...

@uranusjr uranusjr force-pushed the remove-legacy-dangling-ti-hack branch from dffc2b4 to a640340 Compare December 7, 2021 14:17
@uranusjr
Copy link
Member Author

uranusjr commented Dec 7, 2021

Looks like this totally is.

@uranusjr uranusjr marked this pull request as ready for review December 7, 2021 15:12
@uranusjr uranusjr force-pushed the remove-legacy-dangling-ti-hack branch from a640340 to 1f6533a Compare December 7, 2021 15:46
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr uranusjr merged commit b0eecc3 into apache:main Dec 8, 2021
@uranusjr uranusjr deleted the remove-legacy-dangling-ti-hack branch December 8, 2021 05:31
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants