Update known warnings for Python 3.7 #19333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That should fix one of the two erros failing in |
After seting 3.7 the default (apache#19317) the warning printed by Python during importing all providers (specifically apache beam) has slightly changed. Apparently collections.abc warning was a bit more "scary" - warning that it's 3.9 not 3.10 where the old collection imports will stop working (Note that actually this did not happen even in 3.10, apparently) This PR fixes the "known" warning message to match it but also a separate PR (apache/beam#15850) was opened to Beam to get rid of the warnings altogether. Also seems 'dns` stopped generating this warning so I removed it and in case warnings are generated, they are printed outside of the folded group, so that it's immediately visible.
1d12161 to
f29db7c
Compare
|
I also print the Error + warnings outside of the "GA" group so that it's immediately visible in the log (you had to unfold it before to see it). |
jedcunningham
approved these changes
Oct 30, 2021
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
After seting 3.7 the default (#19317) the warning printed by Python during importing all providers (specifically apache beam) has slightly changed. Apparently collections.abc warning was a bit more "scary" - warning that it's 3.9 not 3.10 where the old collection imports will stop working (Note that actually this did not happen even in 3.10, apparently) This PR fixes the "known" warning message to match it but also a separate PR (apache/beam#15850) was opened to Beam to get rid of the warnings altogether. Also seems 'dns` stopped generating this warning so I removed it and in case warnings are generated, they are printed outside of the folded group, so that it's immediately visible. (cherry picked from commit 4bb1317)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
After seting 3.7 the default (#19317) the warning printed by Python during importing all providers (specifically apache beam) has slightly changed. Apparently collections.abc warning was a bit more "scary" - warning that it's 3.9 not 3.10 where the old collection imports will stop working (Note that actually this did not happen even in 3.10, apparently) This PR fixes the "known" warning message to match it but also a separate PR (apache/beam#15850) was opened to Beam to get rid of the warnings altogether. Also seems 'dns` stopped generating this warning so I removed it and in case warnings are generated, they are printed outside of the folded group, so that it's immediately visible. (cherry picked from commit 4bb1317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seting 3.7 the default (#19317) the warning printed by
Python during importing all providers (specifically apache beam)
has slightly changed. Apparently collections.abc warning was
a bit more "scary" - warning that it's 3.9 not 3.10 where the
old collection imports will stop working (Note that actually
this did not happen even in 3.10, apparently)
This PR fixes the "known" warning message to match it but also
a separate PR (apache/beam#15850) was
opened to Beam to get rid of the warnings altogether.
Also seems 'dns` stopped generating this warning so I removed it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.