Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX changelog provider docker 2.0.0 #17008

Closed
wants to merge 1 commit into from
Closed

FIX changelog provider docker 2.0.0 #17008

wants to merge 1 commit into from

Conversation

raphaelauv
Copy link
Contributor

@raphaelauv raphaelauv commented Jul 14, 2021

Since there is a regression in version 2.0.0 , the changelog that is directly show by the documentation ( and so the airflow website ) should let know people about.

this PR will add an option to disable the mount of the temporary directory -> #16932

Since there is a regression in version 2.0.0 , the changelog that is directly show by the documentation ( and so the airflow website ) should let know people about.
@raphaelauv
Copy link
Contributor Author

raphaelauv commented Jul 14, 2021

Should I change the base branch to make this change appear on https://airflow.apache.org/docs/apache-airflow-providers-docker/2.0.0/index.htmll ?

@potiuk
Copy link
Member

potiuk commented Jul 15, 2021

This will be implemented as bugfix in 2.1.0 that willl follow. The description is also wrong. It will only fail when you have Docker-in-Docker or Remote engine, So it does not really fail always, there are a number of cases where it will continue to work.

@potiuk potiuk closed this Jul 15, 2021
@potiuk
Copy link
Member

potiuk commented Jul 15, 2021

Added in #17015

@raphaelauv
Copy link
Contributor Author

ok about the 2.1.0

but

The description is also wrong. It will only fail when you have Docker-in-Docker or Remote engine, So it does not really fail always, there are a number of cases where it will continue to work.

I wrote -> The DockerOperator mount the TemporaryDirectory 'airflowtmp/...' in all case, making fail any docker in docker usage

not that it's failing in all cases

@raphaelauv raphaelauv deleted the patch-1 branch July 15, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants