Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash attempting to mask secrets in dict with non-string keys #16601

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

ashb
Copy link
Member

@ashb ashb commented Jun 22, 2021

Fixes #16597


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@ashb
Copy link
Member Author

ashb commented Jun 22, 2021

Living a bit fast and loose -- CI having problems but ran these changed tests locally.

@ashb ashb merged commit 18cb0bb into apache:main Jun 22, 2021
@ashb ashb deleted the mask-non-str-dictkey branch June 22, 2021 20:49
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jun 22, 2021
ashb added a commit that referenced this pull request Jun 22, 2021
@ashb ashb added this to the Airflow 2.1.1 milestone Jun 22, 2021
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jun 23, 2021
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jun 23, 2021
…pache#16601)

(cherry picked from commit 18cb0bb)
(cherry picked from commit 6af516b)
(cherry picked from commit a1f3daf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airflow logging secrets masker assumes dict_key is type str
3 participants