-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact conn secrets in webserver logs #16579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah I'd changed it to only redact the Task logs.
The other option would be to have the redact filter apply to all of the webserver logs, but that feels heavy weight.
Is the Test Connection button available in 2.1 or is it new in main/2.2? Yup, just checked, new in 2.2.
Yeah, I too thought it to apply for all logs, but then it feels like overburdening web server, hence used specifically. |
(cherry picked from commit 2a59de3)
Since |
God call. Marked it as 2.1.3 |
(cherry picked from commit 2a59de3)
(cherry picked from commit 2a59de3)
(cherry picked from commit 2a59de3)
(cherry picked from commit 2a59de3)
Found sensitive connection attributes in webserver logs while testing a connection from UI.
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.