pass wait_for_done parameter down to _DataflowJobsController #15541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using either
DataflowStartFlexTemplateOperator
,DataflowTemplatedJobStartOperator
orDataflowStartSqlJobOperator
. The parameterwait_until_finished
seems to have no effect which meant the default behavior is observed regardless of what is passed. First experienced this while usingDataflowStartFlexTemplateOperator
to trigger a job in streaming mode and the operator returned success when the job's state changed to running despite passingwait_until_finished: True
.This commit fixes that and passes
wait_until_finished
to the_DataflowJobsController
whereverjobs_controller.wait_for_done()
is called.also noticed here: #13262 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.