Pre-commit cache is tied to a specific python version #14430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Feb 24, 2021
bd2c882 to
b54bb22
Compare
|
a bit more changes needed, I realized :( Yaml rule for spaces in multiline are weird, and I forgot that we have SIX similar cases actually :) |
The Pre-commit cache did not work when there is a change in version of host python version used. When python version changed from 3.6.12 to 3.6.13, the cache rendered useless. This change adds python versio to the cache key specification, including fallback value also including the python version, so that even after changing pre-commit, the cache can be rebuilt from the last-good cache but for the same python version.
b54bb22 to
fc44002
Compare
potiuk
added a commit
that referenced
this pull request
Mar 3, 2021
The Pre-commit cache did not work when there is a change in version of host python version used. When python version changed from 3.6.12 to 3.6.13, the cache rendered useless. This change adds python versio to the cache key specification, including fallback value also including the python version, so that even after changing pre-commit, the cache can be rebuilt from the last-good cache but for the same python version. (cherry picked from commit f3bc8ab)
potiuk
added a commit
that referenced
this pull request
Mar 3, 2021
The Pre-commit cache did not work when there is a change in version of host python version used. When python version changed from 3.6.12 to 3.6.13, the cache rendered useless. This change adds python versio to the cache key specification, including fallback value also including the python version, so that even after changing pre-commit, the cache can be rebuilt from the last-good cache but for the same python version. (cherry picked from commit f3bc8ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pre-commit cache did not work when there is a change in
version of host python version used. When python version changed
from 3.6.12 to 3.6.13, the cache rendered useless.
This change adds python versio to the cache key specification,
including fallback value also including the python version, so
that even after changing pre-commit, the cache can be rebuilt
from the last-good cache but for the same python version.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.