Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Black on Providers Packages #10543

Merged
merged 17 commits into from
Aug 25, 2020
Merged

Enable Black on Providers Packages #10543

merged 17 commits into from
Aug 25, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Aug 25, 2020 •
edited
Loading

This is part of #9550 but only applies Black formatting to providers packages as they are not included in v1-10-test so the problem for cherry-picking them does not arises.

If there are any open PR, they just need to run pre-commit and everything would be taken care off

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:dev-tools provider:amazon AWS/Amazon - related issues labels Aug 25, 2020
@kaxil kaxil requested review from mik-laj, potiuk and turbaszek August 25, 2020 09:15
@potiuk
Copy link
Member

potiuk commented Aug 25, 2020

Great idea to enable black on Providers first!

turbaszek
turbaszek approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Should we apply black on tests/providers?

@kaxil
Copy link
Member Author

kaxil commented Aug 25, 2020

Awesome! Should we apply black on tests/providers?

Yup already applied

@turbaszek
Copy link
Member

Yup already applied

Good! There is too much file to be able to load it all in Github 😄

@sztamas
Copy link

sztamas commented Aug 25, 2020

Hi @kaxil

Could you please also update the isort section in setup.cfg to ignore the providers and api_connexion the same way you ignore them in the pre-commit hook?

A skip_glob=*/api_connexion/**/*.py,*/providers/**/*.py should work.

Thanks,

Tamas

@kaxil
Copy link
Member Author

kaxil commented Aug 25, 2020 •
edited
Loading

aah got your point, will do it, thanks

sztamas added a commit to PyCQA/isort that referenced this pull request Aug 25, 2020
@sztamas
Disable airflow integration tests temporarily.
bddd1d2 
Airflow just enabled Black on api_connexion and providers packages.
They've updated their pre-commit hooks, but forgot to update the
isort section in setup.cfg to ignore all those files.

Left a comment for them to update their setup.cfg.

apache/airflow#10543 (comment)
kaxil added a commit to astronomer/airflow that referenced this pull request Aug 25, 2020
@kaxil
Port isort config from pre-commit to setup.cfg
a0789f8 
Based on apache#10543 (comment)
@kaxil kaxil mentioned this pull request Aug 25, 2020
Merged
@sztamas
Copy link

sztamas commented Aug 25, 2020

Thanks for the fast response! 👍

kaxil added a commit that referenced this pull request Aug 25, 2020
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
a0e7c40 
Based on #10543 (comment)
@turbaszek
Copy link
Member

Should we configure isort to be compatible with black?
https://github.com/TobKed/short_my_url_baby/blob/85d07e5ceffd568f7f5506983cd58658d24d29f9/.pre-commit-config.yaml#L6-L9

@kaxil
Copy link
Member Author

kaxil commented Aug 27, 2020

It is even simpler by adding "black" profile to isort which is in #9550 which applies black to entire airflow repo. Waiting till we are close to 2.0 and then do a big bang so we don't need to cherrypick anymore and can pause the PRs for that time

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2021
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
45cb13b 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
5cb4e44 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
3d5658e 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 25, 2021
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
d177726 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 9, 2022
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
bf24385 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2022
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
6bd9e56 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 6, 2022
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
ba20b3a 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 9, 2022
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
ad51514 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
e500416 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
4b3a6ff 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
a5a93f1 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
62f353c 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
3aa8ef4 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 11, 2024
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
00248b9 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
16dde3d 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2024
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
c3255bf 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 6, 2024
@kaxil
Port isort config from pre-commit to setup.cfg (#10557)
e7a56d9 
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@ad-m ad-m ad-m approved these changes

@turbaszek turbaszek turbaszek approved these changes

@mik-laj mik-laj Awaiting requested review from mik-laj

Assignees
No one assigned
Labels
area:dev-tools provider:amazon AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaxil @potiuk @turbaszek @sztamas @ad-m