Skip to content

Commit

Permalink
Remove unnecessary return value from jenkins_request_with_headers (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
romsharon98 authored Oct 22, 2024
1 parent 509428b commit ccd7b86
Showing 1 changed file with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
ParamType = Union[str, dict, list, None]


def jenkins_request_with_headers(jenkins_server: Jenkins, req: Request) -> JenkinsRequest | None:
def jenkins_request_with_headers(jenkins_server: Jenkins, req: Request) -> JenkinsRequest:
"""
Create a Jenkins request from a raw request.
Expand Down Expand Up @@ -72,7 +72,6 @@ def jenkins_request_with_headers(jenkins_server: Jenkins, req: Request) -> Jenki
raise jenkins.TimeoutException(f"Error in request: {e}")
except URLError as e:
raise JenkinsException(f"Error in request: {e.reason}")
return None


class JenkinsJobTriggerOperator(BaseOperator):
Expand Down Expand Up @@ -117,7 +116,7 @@ def __init__(
self.max_try_before_job_appears = max_try_before_job_appears
self.allowed_jenkins_states = list(allowed_jenkins_states) if allowed_jenkins_states else ["SUCCESS"]

def build_job(self, jenkins_server: Jenkins, params: ParamType = None) -> JenkinsRequest | None:
def build_job(self, jenkins_server: Jenkins, params: ParamType = None) -> JenkinsRequest:
"""
Trigger a build job.
Expand Down Expand Up @@ -207,8 +206,7 @@ def execute(self, context: Mapping[Any, Any]) -> str | None:
)
jenkins_server = self.hook.get_jenkins_server()
jenkins_response = self.build_job(jenkins_server, self.parameters)
if jenkins_response:
build_number = self.poll_job_in_queue(jenkins_response["headers"]["Location"], jenkins_server)
build_number = self.poll_job_in_queue(jenkins_response["headers"]["Location"], jenkins_server)

time.sleep(self.sleep_time)
keep_polling_job = True
Expand Down

0 comments on commit ccd7b86

Please sign in to comment.