Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single-service Implementation #67

Merged
merged 2 commits into from
Jan 11, 2023
Merged

single-service Implementation #67

merged 2 commits into from
Jan 11, 2023

Conversation

lahirujayathilake
Copy link
Member

Wrapped api-service, resource-service, and secret-service into a single service.

  • Required annotations were added to Entities, Services, Configurations, and Repositories
  • New module was added to hold the single-service

@DImuthuUpe
Copy link
Contributor

Looks great @lahirujayathilake. I have added a few comments, most to understand new annotations. I prefer to change the module name though. Can you check if you can integrate the controller and agent into this as well?

@DImuthuUpe
Copy link
Contributor

Please add distribution building functionality into the pom. Here is an example https://github.com/apache/airavata-mft/blob/master/services/resource-service/server/pom.xml#L92

@DImuthuUpe
Copy link
Contributor

Thanks @lahirujayathilake. Please address the review comments added above

@DImuthuUpe DImuthuUpe merged commit 9049a3e into apache:master Jan 11, 2023
@lahirujayathilake lahirujayathilake mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DImuthuUpe DImuthuUpe DImuthuUpe requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahirujayathilake @DImuthuUpe