-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove check for scalar(vertex,edge or path) agtypes in unwind #736
Conversation
MuhammadTahaNaveed
commented
Mar 7, 2023
- Removed check that was disabling unwind to be used on arrays with elements of type vertex,edge or path.
- Added regression tests for unwind.
If you think the block_types variable is no longer needed, please modify the code associated with it as well. Lines 4165 to 4170 in 6e8836b
age/src/backend/parser/cypher_clause.c Lines 1333 to 1336 in b09160f
|
Hi @emotionbug, I did not modify those after seeing this comment. What do you think, should it be modified? |
I think that variable is for the constraint you removed. Because even if you don't, it's already doing nothing with the variable, and it's not what the comment says. |
Ok thanks. I will update the PR. |
0adfc49
to
6de1f1b
Compare
@MuhammadTahaNaveed I'm not sure why your commit description comments say Co-authored-by you? |
- Added regression tests for unwind.
6de1f1b
to
f23dda9
Compare
@jrgemignani Fixed it. |
- Added regression tests for unwind.
- Added regression tests for unwind.