Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CI test for python driver #587

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

MuhammadTahaNaveed
Copy link
Member

What I did

  • Implemented a CI workflow for python driver that ensures that any PR/commit that modifies files under age/drivers/python is passing the tests.
  • Moved docker-compose.yaml file in age/drivers/golang to age/drivers, because this is required to instantiate a postgres instance needed for unit testing.
  • Modified host address of connection params to localhost in 'test_age_py.py' to connect to postgres instance running in docker container.

Additional Context

This workflow will only run if their is a modification in files under age/drivers/python.

- This CI workflow will run python driver unit tests and ensure that any
  PR/commit that modifies files under age/drivers/python is passing the tests.
- Moved docker-compose.yaml file in age/drivers/golang to age/drivers,because
  this is required to instaniate a postgres instance, needed for unit testing.
- Modified host address of connection params to localhost in 'test_age_py.py'
  to connect to postgres instance running in docker container.
@jrgemignani
Copy link
Contributor

@MuhammadTahaNaveed While I am all for these automated tests, I need to put a hold on them for the moment.

Apache org is moving away from Travis CI and we aren't sure of what direction we need to go with these tests - both current and new ones. That is, do they have another CI product they want us to use in place of Travis or can we still continue to use Travis.

If you would like to look into that, that would be really helpful and appreciated

@MuhammadTahaNaveed
Copy link
Member Author

MuhammadTahaNaveed commented Jan 23, 2023

Ok 😅. Is their any forum or something like that where Apache informs about these things ? Btw, this workflow is not using travis, it is using github actions.

@jrgemignani
Copy link
Contributor

Ok 😅. Is their any forum or something like that where Apache informs about these things ? Btw, this workflow is not using travis, it is using github actions.

They informed us via email. Our options are Github actions or Jenkins. Jenkins supports ARM whereas Github actions doesn't.

@jrgemignani jrgemignani merged commit 57ee011 into apache:master Feb 1, 2023
@MuhammadTahaNaveed MuhammadTahaNaveed deleted the python-driver-CI branch February 1, 2023 20:28
jrgemignani added a commit that referenced this pull request Feb 14, 2023
- This CI workflow will run python driver unit tests and ensure that any
  PR/commit that modifies files under age/drivers/python is passing the tests.
- Moved docker-compose.yaml file in age/drivers/golang to age/drivers,because
  this is required to instaniate a postgres instance, needed for unit testing.
- Modified host address of connection params to localhost in 'test_age_py.py'
  to connect to postgres instance running in docker container.
Conflicts:
	drivers/python/test_age_py.py

Co-authored-by: John Gemignani <jrgemignani@gmail.com>
jrgemignani pushed a commit that referenced this pull request Feb 15, 2023
- This CI workflow will run python driver unit tests and ensure that any
  PR/commit that modifies files under age/drivers/python is passing the tests.
- Moved docker-compose.yaml file in age/drivers/golang to age/drivers,because
  this is required to instaniate a postgres instance, needed for unit testing.
- Modified host address of connection params to localhost in 'test_age_py.py'
  to connect to postgres instance running in docker container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants