Issue #388 - Fix python driver build from source #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearranged instructions and added instructions to install from requirements.txt
Fixed a typo 'SqlExcution' on line 62 in exceptions.py file
jrgemignani
approved these changes
Jan 3, 2023
|
@Hunaid2000 Looks good to me. |
|
@Hunaid2000 Your changes look good-- Before I approve these changes, were you able to get the python driver to compile with these changes? |
|
Yes, it works fine on my side with antlr4-python3-runtime v4.9.3 and other changes. |
|
@Hunaid2000 That's great! We can go ahead and close it and merge the changes then. Thank you for your time and effort!!! |
dehowef
approved these changes
Jan 5, 2023
jrgemignani
pushed a commit
that referenced
this pull request
Jan 5, 2023
* Fixed a bug where python driver throws error when build from source * Moved required packages to requirements.txt * Update Readme Rearranged instructions and added instructions to install from requirements.txt * Fixed a typo in exceptions.py file Fixed a typo 'SqlExcution' on line 62 in exceptions.py file
jrgemignani
pushed a commit
that referenced
this pull request
Jan 6, 2023
* Fixed a bug where python driver throws error when build from source * Moved required packages to requirements.txt * Update Readme Rearranged instructions and added instructions to install from requirements.txt * Fixed a typo in exceptions.py file Fixed a typo 'SqlExcution' on line 62 in exceptions.py file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in issue #388.