Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding missing parser files #1205

Closed
wants to merge 1 commit into from

Conversation

ezeeyahoo
Copy link

generated using age/drivers/golang/parser/generate.sh

generated using age/drivers/golang/parser/generate.sh
@github-actions github-actions bot added the master label Sep 1, 2023
@ezeeyahoo
Copy link
Author

Please, if someone from maintainers group do a review of this PR..

@MuhammadTahaNaveed
Copy link
Member

Please, if someone from maintainers group do a review of this PR..

Hi @ezeeyahoo, thanks for the pr.

There was previously a discussion on this thing here #714, can you please go through it?

@jrgemignani
Copy link
Contributor

jrgemignani commented Sep 6, 2023

@ezeeyahoo Why is this needed, these files are meant to be autogenerated?

@maehara-n
Copy link

maehara-n commented Dec 18, 2023

@jrgemignani The automatuc generation of files does not seem to be working.

operating environment

  • golang 1.21.5
  • Get driver with gomod
     github.com/apache/age/drivers/golang v0.0.0-20231212232227-0ea118689d78

The following error is output when building the application.

#0 5.670 # github.com/apache/age/drivers/golang/age
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:42:22: undefined: parser.AgeParser
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:43:21: undefined: parser.AgeVisitor
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:114:9: undefined: parser.AgeVisitor
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:129:52: undefined: parser.AgeoutContext
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:135:52: undefined: parser.VertexContext
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:151:50: undefined: parser.EdgeContext
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:164:50: undefined: parser.PathContext
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:186:51: undefined: parser.ValueContext
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:201:56: undefined: parser.PropertiesContext
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:216:50: undefined: parser.PairContext
#0 5.670 /go/pkg/mod/github.com/apache/age/drivers/golang@v0.0.0-20231212232227-0ea118689d78/age/builder.go:216:50: too many errors

@jrgemignani
Copy link
Contributor

@ezeeyahoo PR #1582 should have addressed this. Is this PR still needed?

@ezeeyahoo
Copy link
Author

No problem, closing it.
Thanks for incorporating required changes.

@ezeeyahoo ezeeyahoo closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants