Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: add timeout value to error details in rejectAfterTimeout #715

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

etr2460
Copy link
Contributor

@etr2460 etr2460 commented Jul 29, 2020

🐛 Bug Fix

We're accidentally hardcoding the timeout value in Superset proper, this provides us a way to get the timeout easily, instead of needing to fetch it from one of many possible redux stores.

to: @ktmud @kristw

@etr2460 etr2460 requested a review from a team as a code owner July 29, 2020 15:28
@vercel
Copy link

vercel bot commented Jul 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/ombfuqk50
✅ Preview: https://superset-ui-git-erik-ritter-timeout-value.superset.vercel.app

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #715 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   24.19%   24.19%           
=======================================
  Files         339      339           
  Lines        7617     7617           
  Branches      925      925           
=======================================
  Hits         1843     1843           
  Misses       5701     5701           
  Partials       73       73           
Impacted Files Coverage Δ
...et-ui-connection/src/callApi/rejectAfterTimeout.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c28e93...44b71ac. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants