Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: dist bar will render value multi times #713

Merged
merged 9 commits into from
Aug 7, 2020
Merged

fix: dist bar will render value multi times #713

merged 9 commits into from
Aug 7, 2020

Conversation

Mikedu1988
Copy link
Contributor

🐛 Bug Fix
related issue: #712

Now irrelevantt records will be removed, only the last applied breakpoints will be rendered.

@Mikedu1988 Mikedu1988 requested a review from a team as a code owner July 28, 2020 11:19
@vercel
Copy link

vercel bot commented Jul 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/92rbm30wb
✅ Preview: https://superset-ui-git-fork-mikedu1988-fix-distbar.superset.vercel.app

@vercel vercel bot temporarily deployed to Preview July 28, 2020 11:34 Inactive
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #713 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
- Coverage   24.19%   24.19%   -0.01%     
==========================================
  Files         339      339              
  Lines        7617     7618       +1     
  Branches      925      925              
==========================================
  Hits         1843     1843              
- Misses       5701     5702       +1     
  Partials       73       73              
Impacted Files Coverage Δ
plugins/legacy-preset-chart-nvd3/src/utils.js 14.18% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23437fa...3fe1fcf. Read the comment docs.

@Mikedu1988
Copy link
Contributor Author

@ktmud

Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I'll try to reproduce and verify later this week.

package.json Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview August 3, 2020 07:01 Inactive
Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktmud ktmud merged commit f64d684 into apache-superset:master Aug 7, 2020
@Mikedu1988
Copy link
Contributor Author

juse one quick question, we forked and built our own superset docker image, how can we pick up this bug fix? should we just try a rebuild? or we need to bump the version for the plugin here and then we build our image based on the newer version. @ktmud

@villebro
Copy link
Contributor

@Mikedu1988 this is now released as version 0.14.21 of @superset-ui/legacy-preset-chart-nvd3 (will be bumped in main Superset repo shortly)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants