-
Notifications
You must be signed in to change notification settings - Fork 271
fix: dist bar will render value multi times #713
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/92rbm30wb |
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
==========================================
- Coverage 24.19% 24.19% -0.01%
==========================================
Files 339 339
Lines 7617 7618 +1
Branches 925 925
==========================================
Hits 1843 1843
- Misses 5701 5702 +1
Partials 73 73
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. I'll try to reproduce and verify later this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to reproduce in https://superset-ui.superset.vercel.app/?path=/story/legacy-chart-plugins-legacy-preset-chart-nvd3-bar--stacked-bar-with-values
and verified it works in the branch: https://superset-ui-git-fork-mikedu1988-fix-distbar.superset.vercel.app/?path=/story/legacy-chart-plugins-legacy-preset-chart-nvd3-bar--stacked-bar-with-values
juse one quick question, we forked and built our own superset docker image, how can we pick up this bug fix? should we just try a rebuild? or we need to bump the version for the plugin here and then we build our image based on the newer version. @ktmud |
@Mikedu1988 this is now released as version |
🐛 Bug Fix
related issue: #712
Now irrelevantt records will be removed, only the last applied breakpoints will be rendered.