Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: pass datasource to metrics control #1438

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

john-bodley
Copy link
Contributor

@john-bodley john-bodley commented Oct 27, 2021

🏠 Internal

A prerequisite for apache/superset#17202, this PR passes the optional datasource property to the MetricsControl component which is already declared here.

Note after apache/superset#17202 is merged the datasourceType property can be deprecated, however for now the must coexist for compatibility reasons.

@john-bodley john-bodley requested a review from a team as a code owner October 27, 2021 06:02
@john-bodley john-bodley requested review from etr2460 and ktmud October 27, 2021 06:02
@vercel
Copy link

vercel bot commented Oct 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/3wqVdFVvtydxwptBmsjaDRi1vJ2q
✅ Preview: https://superset-ui-git-john-bodley-metrics-control-exp-baf3d2-superset.vercel.app

@john-bodley john-bodley changed the title John bodley metrics control expose datasource chore: pass datasource to metrics control Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1438 (b498622) into master (f279549) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1438   +/-   ##
=======================================
  Coverage   30.42%   30.42%           
=======================================
  Files         497      497           
  Lines       10003    10003           
  Branches     1689     1689           
=======================================
  Hits         3043     3043           
  Misses       6714     6714           
  Partials      246      246           
Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 37.83% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 36.00% <ø> (ø)
plugins/plugin-chart-table/src/controlPanel.tsx 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f279549...b498622. Read the comment docs.

@john-bodley john-bodley merged commit f3d6b2e into master Oct 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the john-bodley--metrics-control-expose-datasource branch October 28, 2021 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants