This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
chore: pass datasource to metrics control #1438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
A prerequisite for apache/superset#17202, this PR passes the optional
datasource
property to theMetricsControl
component which is already declared here.Note after apache/superset#17202 is merged the
datasourceType
property can be deprecated, however for now the must coexist for compatibility reasons.