-
Notifications
You must be signed in to change notification settings - Fork 272
chore: export module used in main repo #1425
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/ESHNXg8cT4X8sTBKgJ1Gps3frkfz |
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #1425 +/- ##
=======================================
Coverage 30.43% 30.43%
=======================================
Files 497 497
Lines 10000 10000
Branches 1689 1689
=======================================
Hits 3043 3043
Misses 6711 6711
Partials 246 246
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked that these are indeed needed on superset-frontend
. Btw, should we also export DatasourceType
? It appears to be referenced in one of the test files.
I looked at `DatasourceType` and this has exported from
superset-ui/core/type
…On Mon, Oct 25, 2021 at 6:37 PM Ville Brofeldt ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM, checked that these are indeed needed on superset-frontend. Btw,
should we also export DatasourceType? It appears to be referenced in one
of the test files.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1425 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPMKUXLW33C46TFQTONVALUIUXNRANCNFSM5GU4STIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Best regards,
Yongjie
|
🏠 Internal
export module used in main repo