Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: export module used in main repo #1425

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

zhaoyongjie
Copy link
Contributor

@zhaoyongjie zhaoyongjie commented Oct 25, 2021

🏠 Internal
export module used in main repo

@zhaoyongjie zhaoyongjie requested a review from a team as a code owner October 25, 2021 10:18
@vercel
Copy link

vercel bot commented Oct 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/ESHNXg8cT4X8sTBKgJ1Gps3frkfz
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-exportcolor-superset.vercel.app

@zhaoyongjie zhaoyongjie changed the title chore: export module that use in main repo chore: export module used in main repo Oct 25, 2021
@stephenLYZ
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1425 (d97be92) into master (6bf1c57) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1425   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files         497      497           
  Lines       10000    10000           
  Branches     1689     1689           
=======================================
  Hits         3043     3043           
  Misses       6711     6711           
  Partials      246      246           
Impacted Files Coverage Δ
packages/superset-ui-core/src/color/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf1c57...d97be92. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit 9ecb5de into apache-superset:master Oct 25, 2021
Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked that these are indeed needed on superset-frontend. Btw, should we also export DatasourceType? It appears to be referenced in one of the test files.

@zhaoyongjie
Copy link
Contributor Author

zhaoyongjie commented Oct 25, 2021 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants