Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore(chart-controls): improve typing for mapStateToProps #1171

Merged

Conversation

kgabryje
Copy link
Contributor

Change mapStateToProps.controlState type from this & ExtraControlProps to ControlState

@kgabryje kgabryje requested a review from a team as a code owner June 14, 2021 13:46
@vercel
Copy link

vercel bot commented Jun 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/G3xX4HNfGhiE9EXD9buKUk1MSHWd
✅ Preview: https://superset-ui-git-fork-kgabryje-chore-control-state-type-superset.vercel.app

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1171 (2806acc) into master (d31b3c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1171   +/-   ##
=======================================
  Coverage   29.01%   29.01%           
=======================================
  Files         463      463           
  Lines        9336     9336           
  Branches     1494     1494           
=======================================
  Hits         2709     2709           
  Misses       6415     6415           
  Partials      212      212           
Impacted Files Coverage Δ
plugins/plugin-chart-table/src/controlPanel.tsx 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d31b3c7...2806acc. Read the comment docs.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 53773e3 into apache-superset:master Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants