This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Use "extraScalaTestArgs" to pass extra options to scalatest. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the "argLine" option of scalatest is set in pom.xml and we can't overwrite it from the command line. Ref apache-spark-on-k8s#37
ash211
approved these changes
Jan 26, 2017
|
This is a fine way to do it, but I wonder if a name like "extraScalaTestArgs" would be a clearer name. |
|
@ssuchter Good suggestion. I've updated the name. |
516066f to
8d24bc2
Compare
8d24bc2 to
8a475ba
Compare
|
+1 to merge. |
4df2fae
into
apache-spark-on-k8s:k8s-support-alternate-incremental
ash211
pushed a commit
that referenced
this pull request
Feb 8, 2017
* Use "extraTestArgLine" to pass extra options to scalatest. Because the "argLine" option of scalatest is set in pom.xml and we can't overwrite it from the command line. Ref #37 * Added a default value for extraTestArgLine * Use a better name. * Added a tip for this in the dev docs.
ash211
pushed a commit
that referenced
this pull request
Mar 8, 2017
* Use "extraTestArgLine" to pass extra options to scalatest. Because the "argLine" option of scalatest is set in pom.xml and we can't overwrite it from the command line. Ref #37 * Added a default value for extraTestArgLine * Use a better name. * Added a tip for this in the dev docs.
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
* Use "extraTestArgLine" to pass extra options to scalatest. Because the "argLine" option of scalatest is set in pom.xml and we can't overwrite it from the command line. Ref #37 * Added a default value for extraTestArgLine * Use a better name. * Added a tip for this in the dev docs.
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
…spark-on-k8s#52) * Use "extraTestArgLine" to pass extra options to scalatest. Because the "argLine" option of scalatest is set in pom.xml and we can't overwrite it from the command line. Ref apache-spark-on-k8s#37 * Added a default value for extraTestArgLine * Use a better name. * Added a tip for this in the dev docs.
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
…spark-on-k8s#52) * Use "extraTestArgLine" to pass extra options to scalatest. Because the "argLine" option of scalatest is set in pom.xml and we can't overwrite it from the command line. Ref apache-spark-on-k8s#37 * Added a default value for extraTestArgLine * Use a better name. * Added a tip for this in the dev docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Because the "argLine" option of scalatest is set in pom.xml and we can't
overwrite it from the command line.
Ref #37
How was this patch tested?
When I use this option to set
spark.docker.test.persistMinikubetotrue, the minikube vm wasn't deleted after the integration tests, which is expected.build/mvn -Pkubernetes -Pkubernetes-integration-tests \ -pl resource-managers/kubernetes/integration-tests -am \ -DwildcardSuites=org.apache.spark.deploy.kubernetes.integrationtest.KubernetesSuite \ -DextraScalaTestArgs=-Dspark.docker.test.persistMinikube=true \ integration-test