-
Notifications
You must be signed in to change notification settings - Fork 118
Replace submission v1 with submission v2. #286
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
--- | ||
apiVersion: extensions/v1beta1 | ||
kind: Deployment | ||
metadata: | ||
name: spark-resource-staging-server | ||
spec: | ||
replicas: 1 | ||
template: | ||
metadata: | ||
labels: | ||
resource-staging-server-instance: default | ||
spec: | ||
volumes: | ||
- name: resource-staging-server-properties | ||
configMap: | ||
name: spark-resource-staging-server-config | ||
containers: | ||
- name: spark-resource-staging-server | ||
image: kubespark/spark-resource-staging-server:v2.1.0-kubernetes-0.1.0-alpha.3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this image exist already? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
resources: | ||
requests: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added limits. |
||
cpu: 100m | ||
memory: 256Mi | ||
limits: | ||
cpu: 100m | ||
memory: 256Mi | ||
volumeMounts: | ||
- name: resource-staging-server-properties | ||
mountPath: '/etc/spark-resource-staging-server' | ||
args: | ||
- '/etc/spark-resource-staging-server/resource-staging-server.properties' | ||
--- | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: spark-resource-staging-server-config | ||
data: | ||
resource-staging-server.properties: | | ||
spark.kubernetes.resourceStagingServer.port=10000 | ||
spark.ssl.kubernetes.resourceStagingServer.enabled=false | ||
# Other possible properties are listed below, primarily for setting up TLS. The paths given by KeyStore, password, and PEM files here should correspond to | ||
# files that are securely mounted into the resource staging server container, via e.g. secret volumes. | ||
# spark.ssl.kubernetes.resourceStagingServer.keyStore=/mnt/secrets/resource-staging-server/keyStore.jks | ||
# spark.ssl.kubernetes.resourceStagingServer.keyStorePassword=changeit | ||
# spark.ssl.kubernetes.resourceStagingServer.keyPassword=changeit | ||
# spark.ssl.kubernetes.resourceStagingServer.keyStorePasswordFile=/mnt/secrets/resource-staging-server/keystore-password.txt | ||
# spark.ssl.kubernetes.resourceStagingServer.keyPasswordFile=/mnt/secrets/resource-staging-server/keystore-key-password.txt | ||
# spark.ssl.kubernetes.resourceStagingServer.keyPem=/mnt/secrets/resource-staging-server/key.pem | ||
# spark.ssl.kubernetes.resourceStagingServer.serverCertPem=/mnt/secrets/resource-staging-server/cert.pem | ||
--- | ||
apiVersion: v1 | ||
kind: Service | ||
metadata: | ||
name: spark-resource-staging-service | ||
spec: | ||
type: NodePort | ||
selector: | ||
resource-staging-server-instance: default | ||
ports: | ||
- protocol: TCP | ||
port: 10000 | ||
targetPort: 10000 | ||
nodePort: 31000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not typical to specify a nodeport, and should probably be called out explicitly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is to make the documentation and deployment instructions simpler, basically removing the steps to find the NodePort. |
Large diffs are not rendered by default.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is Deployment compatible with k8s 1.5 (which as of now is "prior version" of k8s)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. maybe we should use
extensions.v1beta1/Deployment
instead of the apps group here. The apps group move happened in 1.6 (https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG.md#deployment-2). I'll verify with the team about the plan for this moving forward.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Deployment from the group
extensions/v1beta1
will work on 1.5, 1.6 and 1.7, and we'll probably deprecate it in 1.8. So, I think we can use that for now, and not apps/v1beta1.