This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Correct readme links #266
Merged
Correct readme links #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lins05
reviewed
May 4, 2017
docs/running-on-kubernetes.md
Outdated
| @@ -83,7 +83,7 @@ the cluster. | |||
| ### Specifying input files | |||
|
|
|||
| Spark supports specifying JAR paths that are either on the submitting host's disk, or are located on the disk of the | |||
| driver and executors. Refer to the [application submission](submitting-applications.html#advanced-dependency-management) | |||
| driver and executors. Refer to the [application submission](submitting-applications.md#advanced-dependency-management) | |||
There was a problem hiding this comment.
The links should be .html - it's for the generated static site, rather than meant to be visited on github.
There was a problem hiding this comment.
Sorry I missed this information! What about the hint that the namespace must be exists? Otherwise I would close this PR.
Thanks!
There was a problem hiding this comment.
Thanks @johscheuer. I think we should make it evident that the namespace should exist, so, that change is valuable.
If you revert the html->md changes, I'll gladly merge this.
d7c4e68 to
45d8b2b
Compare
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 26, 2019
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the links inside the Kubernetes readme. They pointed to
htmlwhich aremdresources. Also I added a note that the Kubernetes namespace must be already present and won't be created if absent.