-
Notifications
You must be signed in to change notification settings - Fork 118
Add kubernetes profile to travis CI yml file #21
Add kubernetes profile to travis CI yml file #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right to me, let's hope this passes. We could consider dropping -Pmesos
and -Pyarn
if builds take too long
I agree, we can probably drop -Pmesos and -Pyarn. In future, we also want to run our own integration tests and ensure they're not flaky. Not sure yet how we can make minikube fit with travis though. |
I'd avoid running the integration tests right this moment since they're unstable, and we should get them to a better place. But yes, we should execute the tests in the near future. |
The Travis build has failed with line length checks.
I'll see if I can fix them. |
The build passes now. I experimented with dropping -Pmesos and -Pyarn. It does not save build time much. Note travis runs JDK7 and JDK8 in parallel. Turn around time is the slowest of the two. |
Perfect. Thanks for carrying out the experiment as well. All green. Merging. |
4c24d9b
into
apache-spark-on-k8s:k8s-support-alternate-incremental
* Add kubernetes profile to travis yml file * Fix long lines in CompressionUtils.scala
* Add kubernetes profile to travis yml file * Fix long lines in CompressionUtils.scala
* Add kubernetes profile to travis yml file * Fix long lines in CompressionUtils.scala
* Add kubernetes profile to travis yml file * Fix long lines in CompressionUtils.scala
* Add kubernetes profile to travis yml file * Fix long lines in CompressionUtils.scala
@ssuchter @foxish @ash211
The current .travis.yml file does not use the kubernetes build profile. This change adds the profile so the CI builds will compile kubernetes code.
Note this may make Travis unhappy again. If fixes are trivial, I can include them in this pull request too.