Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Add kubernetes profile to travis CI yml file #21

Conversation

kimoonkim
Copy link
Member

@ssuchter @foxish @ash211

The current .travis.yml file does not use the kubernetes build profile. This change adds the profile so the CI builds will compile kubernetes code.

Note this may make Travis unhappy again. If fixes are trivial, I can include them in this pull request too.

Copy link

@ash211 ash211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, let's hope this passes. We could consider dropping -Pmesos and -Pyarn if builds take too long

@foxish
Copy link
Member

foxish commented Jan 13, 2017

I agree, we can probably drop -Pmesos and -Pyarn. In future, we also want to run our own integration tests and ensure they're not flaky. Not sure yet how we can make minikube fit with travis though.

@mccheah
Copy link

mccheah commented Jan 13, 2017

I'd avoid running the integration tests right this moment since they're unstable, and we should get them to a better place. But yes, we should execute the tests in the near future.

@kimoonkim
Copy link
Member Author

The Travis build has failed with line length checks.

error file=/home/travis/build/apache-spark-on-k8s/spark/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/CompressionUtils.scala message=File line length exceeds 100 characters line=41
error file=/home/travis/build/apache-spark-on-k8s/spark/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/CompressionUtils.scala message=File line length exceeds 100 characters line=42
error file=/home/travis/build/apache-spark-on-k8s/spark/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/CompressionUtils.scala message=File line length exceeds 100 characters line=43
error file=/home/travis/build/apache-spark-on-k8s/spark/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/kubernetes/CompressionUtils.scala message=File line length exceeds 100 characters line=44

I'll see if I can fix them.

@kimoonkim
Copy link
Member Author

Fixed the long lines. Hope it passes now.

@ash211 and @foxish, I'll experiment with dropping -Pmesos and -Pyarn on my personal fork/travis.

@kimoonkim
Copy link
Member Author

The build passes now.

I experimented with dropping -Pmesos and -Pyarn. It does not save build time much. Note travis runs JDK7 and JDK8 in parallel. Turn around time is the slowest of the two.

  • drop Pmesos and Pyarn (link)
    • oraclejdk7: 27 min 30 sec
    • oraclejdk8: 25 min 14 sec
  • keep Pmesos and Pyarn (link)
    • oraclejdk7: 27 min 57 sec
    • oraclejdk8: 26 min 12 sec

@foxish
Copy link
Member

foxish commented Jan 14, 2017

Perfect. Thanks for carrying out the experiment as well. All green. Merging.

@foxish foxish merged commit 4c24d9b into apache-spark-on-k8s:k8s-support-alternate-incremental Jan 14, 2017
@kimoonkim kimoonkim deleted the add-k8s-to-travis-yml branch January 15, 2017 01:09
ash211 pushed a commit that referenced this pull request Feb 8, 2017
* Add kubernetes profile to travis yml file

* Fix long lines in CompressionUtils.scala
ash211 pushed a commit that referenced this pull request Mar 8, 2017
* Add kubernetes profile to travis yml file

* Fix long lines in CompressionUtils.scala
foxish pushed a commit that referenced this pull request Jul 24, 2017
* Add kubernetes profile to travis yml file

* Fix long lines in CompressionUtils.scala
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 25, 2019
* Add kubernetes profile to travis yml file

* Fix long lines in CompressionUtils.scala
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
* Add kubernetes profile to travis yml file

* Fix long lines in CompressionUtils.scala
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants