This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Support specify CPU cores for driver pod #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash211
approved these changes
Mar 29, 2017
| @@ -64,6 +64,9 @@ private[spark] class Client( | |||
| .map(_.split(",")) | |||
| .getOrElse(Array.empty[String]) | |||
|
|
|||
| // CPU settings | |||
| private val driverCpuCores = sparkConf.getOption("spark.driver.cores").getOrElse("1") | |||
There was a problem hiding this comment.
If there's a config like org.apache.spark.internal.config.DRIVER_MEMORY for driver cores that would be good to use, if not no need to make one
There was a problem hiding this comment.
Yeah, there's not a config like org.apache.spark.internal.config.DRIVER_MEMORY. IMO, we should change the spark core code less as far as possible before we merge to spark master branch, and change kubernetes scheduler will be better.
|
I am not involved on this project, you have the wrong developer. |
|
I think foxish meant @mccheah (note the extra 'c') |
|
Thanks for the contribution @hustcat ! |
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support specify CPU cores for driver pod, such as:
Fix #205 .