This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Add Apache license to a few files #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxish
reviewed
Mar 8, 2017
| @@ -1,2 +1,18 @@ | |||
| # | |||
There was a problem hiding this comment.
Doesn't seem like other META-INF directories under spark-sql or ml-lib have this header.
There was a problem hiding this comment.
Maybe they have an exclusion that ignores license check on that META-INF folder but not this one? Would you like to match that pattern?
There was a problem hiding this comment.
For consistency, that seems like a good idea to match that
|
Looks fine. This should also be cherry-picked onto our release branch, right? |
ash211
added a commit
that referenced
this pull request
Mar 16, 2017
* Add Apache license to a few files * Ignore license check on META-INF service (cherry picked from commit 2a61438)
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
* Add Apache license to a few files * Ignore license check on META-INF service (cherry picked from commit 2a61438)
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
* Add Apache license to a few files * Ignore license check on META-INF service (cherry picked from commit 2a61438)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for
./dev/check-licenseto succeed