Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Remove okhttp from top-level pom #166

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

foxish
Copy link
Member

@foxish foxish commented Mar 3, 2017

Fix #165

I'm having issues running the integration tests but they seemed to pass once.
@cvpatel PTAL

@foxish
Copy link
Member Author

foxish commented Mar 3, 2017

Confirmed that the fix works

@ash211
Copy link

ash211 commented Mar 3, 2017

It will be interesting to see if this does indeed fix the integration tests in Travis. @cvpatel is there an available link to the Jenkins instance you mentioned or is that part of the larger issue #158 ?

@cvpatel
Copy link
Member

cvpatel commented Mar 3, 2017

Just got the public access working about an hour ago... it is:
http://66.128.149.237:8080/job/PR-apache-spark-on-k8s_spark/

Once this fix is in, we'll enable adding the messages to the PRs directly.

For some reason I think the failure leaves the system in a weird state, and requires it be run again...

@foxish
Copy link
Member Author

foxish commented Mar 3, 2017

@cvpatel, does it rebuild the minikube cluster and create new docker images each time? I think that needs it to run pre-integration-test first.

@cvpatel
Copy link
Member

cvpatel commented Mar 3, 2017

It runs the following command, which should do it?
./build/mvn -B clean integration-test -Pkubernetes -Pkubernetes-integration-tests -pl resource-managers/kubernetes/integration-tests -am -Dtest=none -DwildcardSuites=org.apache.spark.deploy.kubernetes.integrationtest.KubernetesSuite

I couldn't even start minikube on the system manually; I have added some cleanup steps in case of failures to stop and delete minikube explicitly, which should hopefully be enough. Trying once more .

@cvpatel
Copy link
Member

cvpatel commented Mar 3, 2017

rerun integration test please

@cvpatel
Copy link
Member

cvpatel commented Mar 3, 2017

@ash211
Copy link

ash211 commented Mar 3, 2017

Nice! Thanks for the assist with testing @cvpatel and for the fix @foxish !

@ash211 ash211 merged commit 8336465 into k8s-support-alternate-incremental Mar 3, 2017
@ash211 ash211 deleted the remove-okhttp branch March 3, 2017 07:08
ash211 pushed a commit that referenced this pull request Mar 8, 2017
foxish added a commit that referenced this pull request Jul 24, 2017
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 25, 2019
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 25, 2019
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants