-
Notifications
You must be signed in to change notification settings - Fork 118
Enable unit tests in Travis CI build #132
Enable unit tests in Travis CI build #132
Conversation
The Travis build triggered by this PR successfully ran unit tests too:
The log from the first sub-build shows 1805 tests from Spark
|
This seems good, and it's the obviously right thing to do to run the tests we have to ensure we don't introduce regressions. We'll need to keep our eyes out for test flakes and lost productivity due to long test durations, but those can be overcome. @kimoonkim I saw you observe a test flake in the linked issue. Can you ignore that here and then we merge this? I think we should move from running 0% of the tests to 99% of the tests and then whittle away at getting the last few ignored ones running too. |
@ash211 Yes, let's merge this as is. We can ignore the newly found flaky test for now, which seems low frequency anyway. |
Works for me! Please be ready to ignore flaky tests if any come up -- hopefully that doesn't happen often. |
0a22b35
into
apache-spark-on-k8s:k8s-support-alternate-incremental
* Configure unit test build while banning flaky tests * Clean up comment
* Configure unit test build while banning flaky tests * Clean up comment
* Configure unit test build while banning flaky tests * Clean up comment (cherry picked from commit 0a22b35)
* Configure unit test build while banning flaky tests * Clean up comment
What changes were proposed in this pull request?
Fixes #110 by setting up unit tests build in Travis CI. The
.travis.yml
is modified to add a parallel build that runs unit tests. The build is configured to target sparkcore
andresource-managers/kubernetes/core
modules and their dependencies.There are some flaky unit tests in
core
. They are excluded using a regex pattern in-Dsuffixes
scalatest option.While we're at it, also drops JDK7 and adds scala linting.
How was this patch tested?
Ran a few times successfully in my personal Travis (See branch
unit-tests-regex-filters
).