Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

inherit IO to get kubectl logs output #13

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

foxish
Copy link
Member

@foxish foxish commented Jan 12, 2017

@ash211 @mccheah I was thinking about the logging that we have, where we redirect output to files.

  • There are no imposed file size limits
  • Fetching it for inspection isn't currently very easy.

Using the container's stdout/stderr instead of redirecting to file the way we do it currently may be advantageous, because it has the logic to rotate logs, and keep 5 of the most recent ones (each 10M in size). This also allows for the use of kubectl logs directly, which would be analogous to yarn logs.

@foxish
Copy link
Member Author

foxish commented Jan 12, 2017

Just throwing this out there. The change appears to work for me. Was there some reason why this was not considered a viable alternative?

@foxish
Copy link
Member Author

foxish commented Jan 12, 2017

The biggest advantage is log streaming using kubectl logs -f <pod-name> which is convenient.

@mccheah
Copy link

mccheah commented Jan 12, 2017

Yup this is a good idea.

Copy link

@ash211 ash211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice to me -- @mccheah would you like to merge?

kubectl logs -f <pod-name> is super useful!

@foxish foxish mentioned this pull request Jan 12, 2017
7 tasks
@mccheah mccheah merged commit c155909 into k8s-support-alternate-incremental Jan 12, 2017
@mccheah mccheah deleted the inheritIO branch January 12, 2017 22:11
ash211 pushed a commit that referenced this pull request Feb 8, 2017
ash211 pushed a commit that referenced this pull request Mar 8, 2017
foxish added a commit that referenced this pull request Jul 24, 2017
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
ifilonenko referenced this pull request in bloomberg/apache-spark-on-k8s Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants