This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ash211 @mccheah I was thinking about the logging that we have, where we redirect output to files.
Using the container's stdout/stderr instead of redirecting to file the way we do it currently may be advantageous, because it has the logic to rotate logs, and keep 5 of the most recent ones (each 10M in size). This also allows for the use of
kubectl logs
directly, which would be analogous toyarn logs
.