This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Extract SSL configuration handling to a separate class #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fec6b6 to
1659810
Compare
|
Soft dependency on #122 to fix merge conflicts as the refactors are done in a chain. |
dd599d4 to
8c69aa9
Compare
1659810 to
4ba1f46
Compare
8c69aa9 to
d1d76b0
Compare
60ce1d9 to
292a862
Compare
d1d76b0 to
693d1ec
Compare
292a862 to
81463b8
Compare
|
@ash211 @foxish @iyanuobidele this had a soft dependency on #122 which is now merged - can we look to review and merge this one now? |
|
LGTM |
foxish
reviewed
Feb 23, 2017
| @@ -688,8 +563,8 @@ private[spark] class Client( | |||
| private def buildDriverSubmissionClient( | |||
| kubernetesClient: KubernetesClient, | |||
| service: Service, | |||
| driverSubmitSslOptions: SSLOptions): KubernetesSparkRestApi = { | |||
| val urlScheme = if (driverSubmitSslOptions.enabled) { | |||
| kubernetesSslConfiguration: KubernetesSslConfiguration): KubernetesSparkRestApi = { | |||
There was a problem hiding this comment.
nit: can we just call it SSLConfiguration? The prefix Kubernetes seems to be everywhere.
ash211
suggested changes
Feb 24, 2017
| val keyStoreURI = Utils.resolveURI(keyStore) | ||
| val isProvidedKeyStoreLocal = keyStoreURI.getScheme match { | ||
| case "file" | null => true | ||
| case "container" => false |
There was a problem hiding this comment.
I think container isn't supposed to work anymore after this change https://github.com/apache-spark-on-k8s/spark/pull/107/files#diff-b5527f236b253e0d9f5db5164bdb43e9R79
ash211
approved these changes
Feb 24, 2017
ash211
pushed a commit
that referenced
this pull request
Mar 8, 2017
* Extract SSL configuration to a separate class * KubernetesSsl -> Ssl, container -> local
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
* Extract SSL configuration to a separate class * KubernetesSsl -> Ssl, container -> local
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
…on-k8s#123) * Extract SSL configuration to a separate class * KubernetesSsl -> Ssl, container -> local (cherry picked from commit 1f8fca0)
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
…on-k8s#123) * Extract SSL configuration to a separate class * KubernetesSsl -> Ssl, container -> local
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less a drag-and-drop of all the SSL related logic.
Part of #109