This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Fix issue with DNS resolution #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxish
commented
Feb 15, 2017
| @@ -76,7 +76,7 @@ private[spark] object Minikube extends Logging { | |||
|
|
|||
| def getDockerEnv: Map[String, String] = synchronized { | |||
| assert(MINIKUBE_EXECUTABLE_DEST.exists(), EXPECTED_DOWNLOADED_MINIKUBE_MESSAGE) | |||
| executeMinikube("docker-env") | |||
| executeMinikube("docker-env", "--shell", "bash") | |||
There was a problem hiding this comment.
Also added this because I switched to a different shell and it was giving me odd errors because our string replacement relies on bash style output
mccheah
suggested changes
Feb 15, 2017
| @@ -44,7 +44,7 @@ private[spark] class KubernetesClusterSchedulerBackend( | |||
| private val EXECUTOR_MODIFICATION_LOCK = new Object | |||
| private val runningExecutorPods = new scala.collection.mutable.HashMap[String, Pod] | |||
|
|
|||
| private val kubernetesMaster = "https://kubernetes" | |||
| private val kubernetesMaster = "https://kubernetes.default.svc" | |||
There was a problem hiding this comment.
Yup this works on my machine. Good find!
I think this string belongs in constants.scala and KubernetesClientBuilder#buildFromWithinPod() can just use that string directly. Remove the kubernetesMaster parameter from that method.
mccheah
approved these changes
Feb 16, 2017
|
Feel free to merge after the build passes. Thanks! |
ash211
approved these changes
Feb 16, 2017
ash211
pushed a commit
that referenced
this pull request
Mar 8, 2017
* Fix issue with DNS resolution * Address comments
foxish
added a commit
that referenced
this pull request
Jul 24, 2017
* Fix issue with DNS resolution * Address comments
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
* Fix issue with DNS resolution * Address comments
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
…flakes Disable more flakey tests
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
* Fix issue with DNS resolution * Address comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112