Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Bumping up kubernetes-client version to fix GKE and local proxy #105

Merged
merged 3 commits into from
Feb 10, 2017

Conversation

foxish
Copy link
Member

@foxish foxish commented Feb 10, 2017

@foxish
Copy link
Member Author

foxish commented Feb 10, 2017

cc @mccheah @iyanuobidele

Copy link

@ash211 ash211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see support for this landing so quickly!

Spark-submit also supports submission through the
local kubectl proxy](https://kubernetes.io/docs/user-guide/connecting-to-applications-proxy/). One can use the
authenticating proxy to communicate with the api server directly without passing credentials to spark-submit.
For example, if our local proxy were listening on port 8001, we would have our submission looking like the following:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention the command to start the local proxy

--conf spark.kubernetes.executor.docker.image=registry-host:5000/spark-executor:latest \
examples/jars/spark_examples_2.11-2.2.0.jar

This mechanism can also be useful when we have authentication schemes that the client library does not support
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarify -- fabric8 client library

mention some example authentication schemes you're referring to

@@ -29,7 +29,7 @@
<name>Spark Project Kubernetes</name>
<properties>
<sbt.project.name>kubernetes</sbt.project.name>
<kubernetes.client.version>1.4.34</kubernetes.client.version>
<kubernetes.client.version>2.0.3</kubernetes.client.version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this crosses a 2.0 boundary -- any backcompat breaks to be worried about?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are release notes for this library? I'm having trouble finding them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None as far as I've checked. It looks like they just chose a sudden version jump a few days ago: https://github.com/fabric8io/kubernetes-client/releases?after=kubernetes-client-2.0.0.fuse-000002

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some packages moved around related to Jobs, but we don't use those so it didn't affect us.

fabric8io/kubernetes-client#646

@iyanuobidele
Copy link

@foxish
This looks great! Thanks for pushing this through. (The upstream changes looked great too!)
LGTM!

@foxish foxish force-pushed the fix-gke-local-kubectl-proxy branch from b7a9cf0 to 61ad354 Compare February 10, 2017 20:46
@foxish foxish force-pushed the fix-gke-local-kubectl-proxy branch from 61ad354 to cde1935 Compare February 10, 2017 20:48
Copy link

@ash211 ash211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- please merge when the tests are green

@foxish foxish merged commit 42b72c5 into k8s-support-alternate-incremental Feb 10, 2017
@ash211 ash211 deleted the fix-gke-local-kubectl-proxy branch February 13, 2017 15:32
ash211 pushed a commit that referenced this pull request Mar 8, 2017
* Bumping up kubernetes-client version to add fixes

* Modify wording

* Addressed comments
foxish added a commit that referenced this pull request Jul 24, 2017
* Bumping up kubernetes-client version to add fixes

* Modify wording

* Addressed comments
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 25, 2019
…he-spark-on-k8s#105)

* Bumping up kubernetes-client version to add fixes

* Modify wording

* Addressed comments
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
…he-spark-on-k8s#105)

* Bumping up kubernetes-client version to add fixes

* Modify wording

* Addressed comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants