Ask the user if they want to force a non-upgrade #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apockill
approved these changes
Nov 29, 2020
|
Is "non-upgrade" a real term? Why not downgrade? |
I used this term to cover both a downgrade and an attempt to "upgrade" to the version that's already installed. |
BestDriverCN
approved these changes
Dec 8, 2020
|
@velovix This seems ready to merge? |
|
I'm still against the "non-upgrade" terminology. I think it would be better to make it clear. Non-upgrade certainly won't translate well |
|
Yeah, and I haven't had a chance to address that yet since this PR is more of a side project. I might get to it this weekend if I feel like it 😏 |
|
@BryceBeagle Is this okay? |
BryceBeagle
reviewed
May 6, 2021
BryceBeagle
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompts the user asking if they want to force a non-upgrade if they're in interactive mode, instead of requiring the
--forceflag.Fixes #16.