Add isort to our linting toolkit #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryceBeagle
suggested changes
Oct 24, 2020
BryceBeagle
reviewed
Oct 24, 2020
|
Oh, yeah, good call! It should be ready to merge now, in that respect. |
BryceBeagle
approved these changes
Oct 25, 2020
BestDriverCN
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
isortto our CI pipeline, which checks the order and format of imports. Developers can useisortto automatically do import sorting for them, and a section on this is now in the README. We configureisortto use the "black" profile, which should prevent any disagreements on import formatting between the two tools. However, in CI, we always runblacklast to give it the final say on formatting.