This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove bidmanager from rubicon tests * updated rubicon tests to not use callBids * remove no longer used artifacts from rubiconBidAdapter_spec
Updated adapters to use `$$PREBID_GLOBAL$$` instead. Now if you change `globalVarName` in `package.json` the tests won't fail.
* Add bidfloor parameter to AOL adapter * Remove errant comma * Fixed AOL adapter mobile endpoint secure support
…d#1614) * Update spotx video adapter to set the spotx_ad_key used in DFP targeting to the bid.adId * Changed spotx adapter to set hb_adid through registerDefaultBidderSetting - Instead of setting the adid to the spotx key in the bid response itself we now set a key bid.spotx_ad_key on the bid and then overwrite the hb_adid using this key.
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing prebid#866 * Minor fix * Enabling User sync pixel * minor fix
* Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter * Code improvement for trustx adapter: changed default price type from gross to net
…rebid#1681) * Update Sovrn adapter. Add test coverage. Enable deal IDs. * HS-271: Avoid using private variables such as _bidsRequested and _bidsReceived in Sovrn adapter and Sovrn tests. * lint * Add bidfloor param to test. * changed post content-type in bidder factory to 'application/json', as this is the stated standard for Prebid 1.0.0. * Revert "changed post content-type in bidder factory to 'application/json', as this is the stated standard for Prebid 1.0.0." This reverts commit 0338ce7. * Changed method for altering contentType so that it is configurable via the ServerRequest object. * Altered PR to conform to change reviews. added unit tests. * Added comment to pass Trion adapter test. * Removed false-y check for request.options. Added request.options config for GET requests. Added test for this second change and removed tests for passing null or undefined member variables into the request.options object. * small optimization to request.options to remove extra object declaration.
* added appnexusAst bidadapter markdown file * updated mediatype native config
* logging error message received from endpoint * removed alias
* Adding an addAdUnits event * Fixing errors
* added new server-to-server testing module * fixed linting errors * s2sTesting module fixes * s2sTesting module fixes * removed "both" option from s2s ab testing module * removed leftover StorageManager reference * s2sTesting module improvements * s2sTesting module improvement * Revert "Merge branch 'bugfix/pbs-adapter-storagemanager' into rubicon-feature/s2s-test-module" This reverts commit be232c6, reversing changes made to 4a3abd7. * minor s2sTesting fixes
* initial commit for video support for pbs * Don't mutate bidRequest
* Implement native click tracking * Fire based on postMessage in adserver creative * Fix tests, add comments * Require landing page urls on native bid responses * Address code review comments
* Added standard bidCpmAdjustment * Fix missing «typeof»
…e/Prebid-official-0.31.0 # Conflicts: # modules/aolBidAdapter.js # test/spec/modules/komoonaBidAdapter_spec.js
….31.0 to aolgithub-master * commit 'e7341c948014a789084849495171d08d4b353d07': (21 commits) Added changelog entry. Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) Rubicon feature/s2s test module (prebid#1678) Renaming of "huddledmasses" adapter into colossusssp (prebid#1701) Don't set non-object configurations (prebid#1704) Update JSDoc for `pbjs.enableAnalytics` (prebid#1565) Add ad units event (prebid#1702) AppnexusAst adapter: logging error message from endpoint (prebid#1697) AppnexusAst bidadapter markdown file (prebid#1696) Change Default Content-Type for POST Requests to 'application/json' (prebid#1681) Code improvement for trustx adapter (prebid#1673) PulsePoint Lite adapter - Enabling Sync pixel (prebid#1686) Update spotx video adapter to set the spotx_ad_key used in DFP (prebid#1614) Fix broken AOL mobile endpoint secure bid requests (prebid#1684) Fix adapter tests that hardcoded pbjs. (prebid#1666) no longer attaching gpt slots to adUnits, which breaks utils.cloneJson(adUnit) (prebid#1676) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Sync with Prebid 0.31.0