Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reorder PohRecorder methods #4941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: reorder PohRecorder methods #4941

wants to merge 1 commit into from
+369 −369

Conversation

jstarry
Copy link

@jstarry jstarry commented Feb 12, 2025

Problem

PohRecorder methods and constructors are in a weird order and make it hard to navigate the code

Summary of Changes

  • Move constructors to the top
  • Move up key methods like fn reset, fn record, and fn tick
  • Move helper private methods below public methods for linear code reading

Fixes #

@jstarry jstarry requested a review from bw-solana February 12, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bw-solana bw-solana Awaiting requested review from bw-solana

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jstarry