Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses enum to specify if AccountsIndexIterator should return items sorted or not #4937

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brooksprumo
Copy link

Problem

The collect_all_unsorted field on the accounts index iterator is sometimes cumbersome due to (1) it being a bool, and (2) it feeling backwards/negative from its true/false meaning.

Summary of Changes

Use an enum instead. This way it is self documenting.

@brooksprumo brooksprumo self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant